PR_26179_CHARLIE_026-sprites-palette-panel#262
Conversation
ToolboxAid
changed the base branch from
PR_26179_CHARLIE_025-sprites-basic-drawing
to
main
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45311fb816
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .sprite-canvas-cell--ink, | ||
| .sprite-color-chip--ink { | ||
| background: var(--text) |
There was a problem hiding this comment.
The sprites page only links assets/theme-v2/css/theme.css, and that bundle does not import gamefoundrystudio.css, so these new palette/cell color rules are never loaded at runtime. In this context, selecting Gold/Blue toggles classes in JS, but the chips and painted pixels get no palette-specific styling, leaving the new color-selection feature visually ineffective.
Useful? React with 👍 / 👎.
| .sprite-canvas-cell--orange, | ||
| .sprite-color-chip--orange { | ||
| background: var(--molten-orange) |
There was a problem hiding this comment.
When these palette styles are loaded, painted cells still keep the old ink background because each cell gets both is-painted and a color class, and .sprite-canvas-cell.is-painted has higher specificity than these one-class color selectors. In that scenario Pencil/Fill with Orange/Gold/etc. still render as var(--text) instead of the selected palette color, so the color rules need to match or exceed the painted-cell selector specificity.
Useful? React with 👍 / 👎.
| Team: CHARLIE | ||
| Workflow: stacked feature workflow | ||
| Base branch: PR_26179_CHARLIE_025-sprites-basic-drawing | ||
| Canonical ZIP path: dev/workspace/zip/PR_26179_CHARLIE_026-sprites-palette-panel_delta.zip |
There was a problem hiding this comment.
The repo packaging instructions require every BUILD artifact at <project folder>/tmp/<TASK_NAME>_delta.zip, but this report declares dev/workspace/zip/... as canonical. In the build/evaluation context that consumes these reports, the delta ZIP will be looked for under tmp, so documenting and producing the alternate path can leave the required artifact undiscoverable.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
node --check assets/toolbox/sprites/js/index.jsPASSnode --check dev/tests/playwright/tools/SpritesToolShell.spec.mjsPASSgit diff --check ...PASSnpx playwright test dev/tests/playwright/tools/SpritesToolShell.spec.mjs --workers=1 --reporter=list --output=<temp>PASS, 1 test passedArtifact
dev/workspace/zip/PR_26179_CHARLIE_026-sprites-palette-panel_delta.zip